Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[A11Y] Discussion reply count (mark as read) is button with no accessible information #3368

Closed
Tracked by #3360
davwheat opened this issue Jul 20, 2021 · 1 comment
Closed
Tracked by #3360

[A11Y] Discussion reply count (mark as read) is button with no accessible information #3368

davwheat opened this issue Jul 20, 2021 · 1 comment
Assignees
@davwheat
Labels
type/accessibility Issues relating to accessibility (keyboard navigation, screenreaders, text contrast, etc.)

Comments

@davwheat
Copy link
Member

davwheat commented Jul 20, 2021 •
edited
Loading

image

While having these as buttons make sense to visual users, using ChromeVox allows us to hear what a screenreader user will hear:

test general flarumite replied 8 days ago

1 button

Preferably this should be "1 reply". Multiple replies should be "3 replies". The unread version should be "1 new reply. Mark as read.".
@davwheat davwheat self-assigned this Jul 20, 2021
@davwheat davwheat added the type/accessibility Issues relating to accessibility (keyboard navigation, screenreaders, text contrast, etc.) label Jul 20, 2021
@askvortsov1 askvortsov1 transferred this issue from flarum/framework Mar 10, 2022
@davwheat davwheat mentioned this issue Mar 28, 2022
Open
28 tasks
@davwheat davwheat transferred this issue from flarum/issue-archive Mar 28, 2022
@SychO9
Copy link
Member

SychO9 commented Nov 5, 2023

fixed in #3090

@SychO9 SychO9 closed this as completed Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davwheat davwheat

Labels
type/accessibility Issues relating to accessibility (keyboard navigation, screenreaders, text contrast, etc.)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davwheat @SychO9