Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[A11Y] Add missing attributes to modal #3516

Closed
Tracked by #3360
davwheat opened this issue Aug 22, 2021 · 1 comment · Fixed by #3456
Closed
Tracked by #3360

[A11Y] Add missing attributes to modal #3516

davwheat opened this issue Aug 22, 2021 · 1 comment · Fixed by #3456
Assignees
@davwheat
Labels
type/accessibility Issues relating to accessibility (keyboard navigation, screenreaders, text contrast, etc.)
Milestone
1.5

Comments

@davwheat
Copy link
Member

davwheat commented Aug 22, 2021 •
edited
Loading

Note: this could be performed during a migration to <dialog> HTML elements.
@davwheat davwheat changed the title Add a11y attributes to modal (could be part of migration to native HTML5 <dialog> element) [A11Y] Add missing attributes to modal Aug 22, 2021
@askvortsov1 askvortsov1 transferred this issue from flarum/framework Mar 10, 2022
@davwheat davwheat mentioned this issue Mar 28, 2022
Open
28 tasks
@davwheat davwheat transferred this issue from flarum/issue-archive Jul 11, 2022
@davwheat davwheat mentioned this issue Jul 11, 2022
Merged
8 tasks
@davwheat davwheat added the type/accessibility Issues relating to accessibility (keyboard navigation, screenreaders, text contrast, etc.) label Jul 11, 2022
@davwheat davwheat added this to the 1.5 milestone Jul 11, 2022
@davwheat
Copy link
Member Author

Added this and the PR to the milestone as the PR's main focus isn't this issue itself.

@davwheat davwheat self-assigned this Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davwheat davwheat

Labels
type/accessibility Issues relating to accessibility (keyboard navigation, screenreaders, text contrast, etc.)
Projects
None yet
Milestone
1.5
1 participant
@davwheat