Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USE_V1_PUBLISH_BLOCK_ENDPOINT flag works the wrong way around #581

Closed
alextes opened this issue Feb 9, 2024 · 1 comment
Closed

USE_V1_PUBLISH_BLOCK_ENDPOINT flag works the wrong way around #581

alextes opened this issue Feb 9, 2024 · 1 comment

Comments

@alextes
Copy link
Contributor

alextes commented Feb 9, 2024

The flag appears to use the publish exactly the wrong way around.

if c.ffUseV1PublishBlockEndpoint {                                                                   
	uri = fmt.Sprintf("%s/eth/v2/beacon/blocks?broadcast_validation=%s", c.beaconURI, broadcastMode) 
} else {                                                                                             
	uri = fmt.Sprintf("%s/eth/v1/beacon/blocks", c.beaconURI)                                        
}                                                                                                    

if c.ffUseV1PublishBlockEndpoint {

@avalonche
Copy link
Collaborator

Resolved as part of #585. Thank you for raising this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants