New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging setup and cli arg handling could be cleaner #38

Open

metachris opened this issue Jun 2, 2024 · 0 comments

Contributor

metachris commented Jun 2, 2024

Logging and CLI arg handling is a bit hacky.

For instance:

some vars defined here and reused:

relayscan/cmd/service/service.go

Line 10 in 3a3dcb2

log = common.Logger
logging actually instantiated here: https://github.com/flashbots/relayscan/blob/3a3dcb24167078f66952ad41034124360ba6bbec/common/logging.go

Improvements:

Switch to https://github.com/urfave/cli for CLI argument handling
Switch to built-in logger (see also https://github.com/flashbots/go-template/blob/main/cmd/cli/main.go#L26)

metachris changed the title ~~Logging setup could be cleaner~~ Logging setup and cli arg handling could be cleaner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment