Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests broken on Windows #747

Open
HoldYourWaffle opened this issue Nov 20, 2023 · 2 comments
Open

Tests broken on Windows #747

HoldYourWaffle opened this issue Nov 20, 2023 · 2 comments

Comments

@HoldYourWaffle
Copy link
Contributor

HoldYourWaffle commented Nov 20, 2023

There are currently 482 failing tests on (my) Windows.
Most seem to be related to the snapshot tests' shoddy newline handling (spatie/phpunit-snapshot-assertions#105), I've also seen some weird stuff with a lodata:: prefix in OpenApi description's, and there seem to be various other "things went wrong" errors.

I'm putting this here mainly for visibility, I'll try to investigate further later.
In the meantime I'll run everything through WSL as a workaround :)

@27pchrisl
Copy link
Contributor

I've pushed a change that should resolve this to the 5.x branch, you might have to re-checkout the repository to get the changes, but git might handle it automatically.

@HoldYourWaffle
Copy link
Contributor Author

Oh wow, thanks for the quick response!
As of 3589dab there are about 95 failures left, ranging from dependency shenanigans, more line ending funsies and some random 500-status errors, varying with the combination of PHP and Lodata version for extra spice.

I haven't been able to investigate them in excruciating detail, though I have attempted to add Windows to the CI matrix.
You can see the progress (and a record of me slowly losing my sanity) on the ci--windows branch of my fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants