Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the "by Kinvolk" in the OS release and motd #1483

Open
vbatts opened this issue Jun 26, 2024 · 3 comments
Open

update the "by Kinvolk" in the OS release and motd #1483

vbatts opened this issue Jun 26, 2024 · 3 comments
Labels
kind/enhancement Enhancement of an existing component.

Comments

@vbatts
Copy link
Member

vbatts commented Jun 26, 2024

Description

When ssh'ing to a flatcar instance it still says "by Kinvolk" in the motd

Impact

not a big deal, but Kinvolk was acquired 3yrs ago and Flatcar is an independent community.

Environment and steps to reproduce

  1. Set-up: spin up a Flatcar machine
  2. Task: ssh to it to see the MOTD (/etc/motd). Also look in the PRETTY_NAME= of /etc/os-release

image

Expected behavior

maybe "Flatcar Container Linux (https://github.com/flatcar)" ?

@vbatts vbatts added the kind/bug Something isn't working label Jun 26, 2024
@tormath1 tormath1 added kind/enhancement Enhancement of an existing component. and removed kind/bug Something isn't working labels Jun 27, 2024
@tormath1
Copy link
Contributor

tormath1 commented Jun 27, 2024

Having a Github URL in the MOTD can be a burden to maintain? (e.g we changed two or three times the Github organization name kinvolk -> flatcar-linux -> flatcar).
What about "Flatcar Container Linux (https://flatcar.org/docs)"

@till
Copy link

till commented Jun 27, 2024

IMO, shortening the distro name would be good. I know various tools like Ansible use the names to guess the environment. Maybe that requires coordination?

@jepio
Copy link
Member

jepio commented Jun 27, 2024

There was a bug 2 years back which changed how ansible reports this (ansible/ansible#77537), so I think ansible users will have needed to learn how to handle both (image-builder does).

But if the CNCF submission goes through, that might be a good moment to drop "by Kinvolk".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement of an existing component.
Projects
Status: 📝 Needs Triage
Development

No branches or pull requests

4 participants