Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project license should link to license #3

Open
hadess opened this issue Nov 29, 2018 · 4 comments
Open

Project license should link to license #3

hadess opened this issue Nov 29, 2018 · 4 comments

Comments

@hadess
Copy link

hadess commented Nov 29, 2018

The appdata just says:

    <project_license>LicenseRef-proprietary AND GPL-2.0 AND LGPL-2.1-only</project_license>

Ideally this would link to the license online, similarly to those other projects on Flathub:

    <project_license>LicenseRef-proprietary=https://botfather.io/docs/legal/tos/</project_license>
    <project_license>LicenseRef-proprietary=https://code.visualstudio.com/license</project_license>
    <project_license>LicenseRef-proprietary=https://raw.githubusercontent.com/snes9xgit/snes9x/master/docs/snes9x-license.txt AND LGPL-2.1</project_license>
    <project_license>LicenseRef-proprietary=https://wwwimages2.adobe.com/content/dam/acom/en/legal/licenses-terms/pdf/Flash_Player_30_0.pdf</project_license>
    <project_license>LicenseRef-proprietary=https://www.spotify.com/us/legal/end-user-agreement/</project_license>
    <project_license>LicenseRef-proprietary=https://www.sublimetext.com/eula</project_license>
@wberrier
Copy link
Collaborator

I agree, and when originally created the appdata intended to do so, but was unable to find a url to the license text.

@hadess
Copy link
Author

hadess commented Nov 29, 2018

Maybe https://www.makemkv.com/buy/ would be good enough?

@wberrier
Copy link
Collaborator

wberrier commented Dec 2, 2018

I don't have strong objections to that, but putting a "purchase" link inside a license link seems a bit of a misuse... ? Thoughts?

I could also ask the developer to post the license on his website and link to that.

@ablackbu
Copy link

ablackbu commented Jan 14, 2019

For what its worth the license is in the bin release so I would imagine you have it every time you update the flatpak based on the way it is packed into the bin. For example on 1.14.2 release -> makemkv-bin-1.14.2/src/eula_en_linux.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants