Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unofficial vaapi encoding #51

Open
polluxau opened this issue Apr 20, 2024 · 2 comments
Open

unofficial vaapi encoding #51

polluxau opened this issue Apr 20, 2024 · 2 comments

Comments

@polluxau
Copy link

would vaapi encoding work under guilded? as it uses electron but trying some variables it doesnt seem to be working properly,
i used

--enable-features=UseOzonePlatform --use-gl=angle --use-angle=gl --enable-features=VaapiVideoEncoder, VaapiIgnoreDriverChecks, VaapiVideoDecoder, CanvasOopRasterization

it just shows a blank screenshare and doesnt go any further
Screenshot_20240420_132822

and this is what comes up when running it through terminal and trying to screenshare with those vaapi env enabled

[3:0420/132926.042930:ERROR:egl_dmabuf.cc(407)] Error during eglInitialize: EGL_NOT_INITIALIZED
'loop->recurse > 0' failed at ../src/pipewire/thread-loop.c:417 pw_thread_loop_wait()
[3:0420/132931.023134:ERROR:egl_dmabuf.cc(407)] Error during eglInitialize: EGL_NOT_INITIALIZED
[OpenH264] this = 0x0x3d080b688930, Warning:Actual input framerate 0.000000 is different from framerate in setting 29.000000, suggest to use other rate control modes

seems it cant do the right frame rate with openh264?

@losuler
Copy link
Collaborator

losuler commented Apr 20, 2024

We'd have to try and see if VAAPI works on Guilded in their official release first. If that works, then we can rule out it being a Guilded or Electron issue. I know it isn't working on Discord from personal experience (e.g. flathub/com.discordapp.Discord#359). I also saw similar discussion on the Chromium Flatpak (flathub/org.chromium.Chromium#266). Being on Wayland (such as I am) is also another factor.

@polluxau
Copy link
Author

We'd have to try and see if VAAPI works on Guilded in their official release first. If that works, then we can rule out it being a Guilded or Electron issue. I know it isn't working on Discord from personal experience (e.g. flathub/com.discordapp.Discord#359). I also saw similar discussion on the Chromium Flatpak (flathub/org.chromium.Chromium#266). Being on Wayland (such as I am) is also another factor.

I see, yeah vencord devs have been working on enabling vaapi encoding under vesktop and fixing the issues with other things with their api they use, it is done now and iv tested it, it works great and as intended

Will see what happens :)

Vencord/Vesktop#489

Vencord/Vesktop#499

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants