File downloads do not work

[faveoled]

E.g. "Download image" (ERD diagram view), "Save results to file" (query output window view) fail silently.
The file picker allows specifying the file name though.

[razzeee]

Ideally, the app/electron would just use the file portal. Which it should try to do according to https://github.com/pgadmin-org/pgadmin4/blob/9645bb391170a0cb7033bb6e5f38fee192c7b4c6/web/pgadmin/misc/file_manager/static/js/FileManagerModule.jsx#L114 - not sure how exactly it works, but are we not using the runtime they provide but end up on the browser path?

https://github.com/pgadmin-org/pgadmin4/blob/master/runtime/package.json seems to be the part of the project relevant for wrapping everything in electron

[razzeee]

I fail at getting pgadmin to build and run locally - it seems, like even the normal shipped (deb or whatever) is also not using the filepicker portal. At least in gnomes case, it's still opening the old interface.

[razzeee]

So from playing with https://github.com/electron/electron-quick-start it seems like:

1. It does the correct thing, when you just use a <input="file" /> html tag
2. It uses the wrong window, if you call the dialog api https://www.electronjs.org/docs/latest/api/dialog

Ideally pgadmin rewrites to use the former.

[razzeee]

Okay, this might actually just be the electron version and the revert of the file portal changes?

It seems to work fine with quickstart in all cases, if I pin it to 31.2.1