Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry is only checking for ECONN error #330

Open
potatoronin opened this issue Nov 25, 2019 · 0 comments
Open

Retry is only checking for ECONN error #330

potatoronin opened this issue Nov 25, 2019 · 0 comments

Comments

@potatoronin
Copy link

potatoronin commented Nov 25, 2019

https://github.com/flatiron/cradle/blob/master/lib/cradle.js#L217

The retry is only triggered for ECON (refused, reset). What about e.g. ESOCKETTIMEDOUT / ETIMEDOUT?

Or e.g. Intentional server error like 429 Too Many requests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant