detect un-fired vows on exit, and report error

vowsjs · Jun 17, 2010 · 3d1217a · 3d1217a
1 parent e1d1ea5
commit 3d1217a
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 1 deletion.
diff --git a/lib/vows.js b/lib/vows.js
@@ -139,11 +139,31 @@ process.addListener('exit', function () {
             vows.reporter.report(['error', { error: "Asynchronous Error", suite: s }]);
         }
         s.batches.forEach(function (b) {
+            var unFired = [];
+
+            b.vows.forEach(function (vow) {
+                if (! vow.status) {
+                    if (unFired.indexOf(vow.context) === -1) {
+                        unFired.push(vow.context);
+                    }
+                }
+            });
+
+            if (unFired.length > 0) { sys.print('\n') }
+
+            unFired.forEach(function (title) {
+                sys.puts(console.error({
+                    error: "not fired!",
+                    context: title,
+                    batch: b,
+                    suite: s
+                }));
+            });
+
             if (b.status === 'begin') {
                 failure = true;
                 results.errored ++;
                 results.total ++;
-                vows.reporter.report(['error', { error: "A callback hasn't fired", batch: b, suite: s }]);
             }
             Object.keys(results).forEach(function (k) { results[k] += b[k] });
         });

diff --git a/lib/vows/console.js b/lib/vows/console.js
@@ -72,3 +72,8 @@ this.result = function (event) {
 this.inspect = function inspect(val) {
     return '\033[1m' + eyes(val) + '\033[22m';
 };
+
+this.error = function (obj) {
+    return '✗ ' + $('Errored ').red + '» '
+                + $('' + $(obj.context).italic + ' ∙ ' + obj.error).red;
+};