Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the 'addRewriter' to winston #258

Closed
wants to merge 3 commits into from

Conversation

machadogj
Copy link
Contributor

I am not sure why this was not added, but this simple change would allow people to add rewriters to the default logger without having to do a lot of changes to their code.

@machadogj
Copy link
Contributor Author

I know this is duplicated of #139, but the #139 hasn't been addressed yet.

a0viedo and others added 2 commits August 25, 2014 10:23
…ing and qs Denial-of-Service Memory Exhaustion (vulnerable versions <1.0.0)
updated request to fix qs Denial-of-Service Extended Event Loop Blocking...
@indexzero
Copy link
Member

This is correct, but rewriters will go away in winston@1.0.0. So this will go into the next winston@0.8.x, but we will only cherry-pick this commit: machadogj@18612d0

@indexzero
Copy link
Member

Cherrypicked. Thanks!

@indexzero indexzero closed this Oct 6, 2014
@flarn2006
Copy link

This is a duplicate of #258; shouldn't it be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants