[fix] catch exceptions for file transport unlinkSync #266
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using cluster, I sometimes run more than one winston logger on a
single instance. Occasionally they both detect that they should
remove the log file, and one will unlink before the other. This
adds a try...catch to make sure that the unlinkSync call doesn't
throw.
I'd be happy to modify the PR to provide some way of notifying the
developer that the unlink failed. I didn't see a good one off the bat,
ordinarily I'd use something like debug().