Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi Device Support #26

Open
garrettwrong opened this issue May 29, 2020 · 2 comments
Open

Multi Device Support #26

garrettwrong opened this issue May 29, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@garrettwrong
Copy link
Collaborator

Longer term, I think it would be good if we could naively use multi gpu in an embarrassingly parallel way. That is, cufinufft keeps the responsibility of managing device choice and user gpu data (on correct device) outside of cufinufft. What makes it a bit complicated is how that is managed. One approach would require notion of driver context that is passed through (the device and memory is bound to that context and owned/managed by the caller). This obviously would be optional.

There are more involved ways to do multi gpu, but I think this would be a good balance, and the least disruptive.

For a production size ASPIRE workload, this would be a great performance opportunity. Currently the testing sizes are limited by the memory bounds. One can imagine just running the largest batch that will fit on a single GPU concurrently on two or four separate gpus (common configurations for HPC nodes).

This is not anything immediate, just something I think is worth considering.

@garrettwrong garrettwrong added the enhancement New feature or request label May 29, 2020
@janden
Copy link
Collaborator

janden commented Jun 4, 2020

That is, cufinufft keeps the responsibility of managing device choice and user gpu data (on correct device) outside of cufinufft.

I don't quite understand. Are you saying that cufinufft is not responsible for coordinating data between devices, but that it's up to the user? In that case, cufinufft just needs to play nice and not get confused when different devices or contexts are used?

@JBlaschke
Copy link
Contributor

FYI, I've implemented some very basic multi-GPU support here: #71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants