-
Notifications
You must be signed in to change notification settings - Fork 81
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add binding for spread and interpolate, and also maybe support density estimator #306
Comments
@wendazhou is writing a faster spreader as a separate repo, which we hope to then use in finufft. But for now if you work in C++ you can already call anything in libfinufft.so, looking in the finufft::spreadinterp namespace. You could easily write a Py wrapper to them. But writing wrappers exposing them cleanly from all 5 languages is not worth it for us yet. |
If I do happen to write the interface for python, can I make a PR? |
Hi @chaithyagr , As Alex mentioned, I am in the process of finishing up a standalone spreading package which should be significantly more performant (making use of explicit vectorization) and flexible (e.g. user configurable polynomial weights, spreading to both real-valued and complex-valued targets etc.) and an initial version should be available next week. I will probably have some rudimentary python bindings by then. Did you have a specific application / problem in mind? I can try to check if your usage would fit within the API of that package, and modify the API if necessary. |
Hi @wendazhou , I have made my PR, the uses of it is in mri-nufft, which is applied specifically for MRI, and to estimate the Density compensators. |
Updates:
|
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
The spread and interpolate are equally important kernels and it will be nice to have them exposed also.
Additionally, it would help to have density compensation estimators in place.
Most are implemented in
tensorflow-nufft
andtensorflow-mri
already (although these features are not limited to MRI)The text was updated successfully, but these errors were encountered: