Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[node] NotImplementedError: Git sources in lockfile v2 format are not supported yet #381

Open
Tracked by #16
Ian2020 opened this issue Nov 3, 2023 · 1 comment · May be fixed by #382
Open
Tracked by #16

[node] NotImplementedError: Git sources in lockfile v2 format are not supported yet #381

Ian2020 opened this issue Nov 3, 2023 · 1 comment · May be fixed by #382
Labels
bug node

Comments

@Ian2020
Copy link

Ian2020 commented Nov 3, 2023

flatpak-builder version

1.3.3

Linux distribution and version

Fedora 38

Affected flatpak-builder tool

node/flatpak-node-generator.py

flatpak-builder tool cli args

npm package-lock.json

Source repository URL

No response

Flatpak-builder manifest URL

https://github.com/Ian2020/io.onlykey.OnlyKey-App/blob/main/io.onlykey.OnlyKey-App.yaml

Description

As title and as intended at the moment the node tool does not support git sources for lockfile v2.

For example fragment of a lockfile below, the nw dependency causes the issue:

{
  "name": "OnlyKey",
  "version": "5.5.0",
  "lockfileVersion": 3,
  "requires": true,
  "packages": {
    "": {
      "name": "OnlyKey",
      "version": "5.5.0",
      "license": "Apache-2.0",
      "dependencies": {
        "auto-launch": "^5.0.5",
        "js-sha256": "^0.9.0",
        "nw": "git+https://git@github.com/Ian2020/npm-installer.git#8e1575a4abf16901924a6146835334ddeaa17b14",
        "nw-autoupdater": "^1.1.11",
        "request": "^2.88.2",
        "sshpk": "^1.17.0"
      },
      "devDependencies": {
        "chai": "^4.3.7",
        "chai-as-promised": "^7.1.1",
        "eslint": "^8.33.0",
        "fs-jetpack": "^5.1.0",
        "gulp": "^4.0.2",
        "gulp-sourcemaps": "^3.0.0",
        "json": "^11.0.0",
        "mocha": "^10.2.0",
        "nw-dev": "^3.0.1",
        "q": "^1.5.1",
        "selenium-webdriver": "^4.8.0",
        "tree-kill": "^1.2.2",
        "yargs": "^17.6.2"
      },
      "optionalDependencies": {
        "appdmg": "^0.6.4"
      }
    },
   ...
@Ian2020 Ian2020 added the bug label Nov 3, 2023
@Ian2020 Ian2020 linked a pull request Nov 3, 2023 that will close this issue
Open
@jwillikers
Copy link

I need this as well to update the Stretchly Flatpak to the latest version.

@dylanmccall dylanmccall mentioned this issue Nov 23, 2023
Merged
@faveoled faveoled mentioned this issue Dec 29, 2023
Closed
8 tasks
@GarboMuffin GarboMuffin mentioned this issue Feb 5, 2024
Closed
2 tasks
p2004a added a commit to p2004a/info.beyondallreason.bar that referenced this issue Mar 3, 2024
@p2004a
Update launcher to the latest version
ac3ff3b 
As part of the update, I had to refactor quite a bit of how the build
process works.

flatpak-node-generator is quite bugged:
 - Output `generated-source.json` expects the package to be in the main
   directory, so I've split the build into modules but still had to add
   `flatpak-node` exclusion to build
 - I had to patch locally flatpak/flatpak-builder-tools#382
   and use that because flatpak/flatpak-builder-tools#381
 - I've also run into flatpak/flatpak-builder-tools#377

I've also:
 - Made copying of addr2line dependencies more reliable
 - Merged the startup scripts into one
 - Added permission and setup for discord so that rich presence works
p2004a added a commit to p2004a/info.beyondallreason.bar that referenced this issue Mar 3, 2024
@p2004a
Update launcher to the latest version
a22d422 
As part of the update, I had to refactor quite a bit of how the build
process works.

flatpak-node-generator is quite bugged:
 - Output `generated-source.json` expects the package to be in the main
   directory, so I've split the build into modules but still had to add
   `flatpak-node` exclusion to build
 - I had to patch locally flatpak/flatpak-builder-tools#382
   and use that because flatpak/flatpak-builder-tools#381
 - I've also run into flatpak/flatpak-builder-tools#377

I've also:
 - Made copying of addr2line dependencies more reliable
 - Merged the startup scripts into one
 - Added permission and setup for discord so that rich presence works
@p2004a p2004a mentioned this issue Mar 3, 2024
Merged
p2004a added a commit to flathub/info.beyondallreason.bar that referenced this issue Mar 3, 2024
@p2004a
Update launcher to the latest version
738cde4 
As part of the update, I had to refactor quite a bit of how the build
process works.

flatpak-node-generator is quite bugged:
 - Output `generated-source.json` expects the package to be in the main
   directory, so I've split the build into modules but still had to add
   `flatpak-node` exclusion to build
 - I had to patch locally flatpak/flatpak-builder-tools#382
   and use that because flatpak/flatpak-builder-tools#381
 - I've also run into flatpak/flatpak-builder-tools#377

I've also:
 - Made copying of addr2line dependencies more reliable
 - Merged the startup scripts into one
 - Added permission and setup for discord so that rich presence works
@hfiguiere hfiguiere added the node label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug node
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[node] support git sources in lockfile v2 format Ian2020/flatpak-builder-tools
3 participants
@hfiguiere @Ian2020 @jwillikers