Node generator don't create symlink to SHASUMS256.txt, electron/get gets cache miss

[savely-krasovsky]

flatpak-builder version

1.4.2

Linux distribution and version

Arch Linux

Affected flatpak-builder tool

node/flatpak-node-generator.py

flatpak-builder tool cli args

No response

Source repository URL

No response

Flatpak-builder manifest URL

No response

Description

I am using @electron/forge (not electron-builder). I got it work, but manually patched special.py with this:

self.gen.add_shell_source(
    [
        f'mkdir -p "{sanitized_url}"',
        f'ln -s "../{binary.filename}" "{sanitized_url}/{binary.filename}"',
        f'mkdir -p "{url_hash}"',
        f'ln -s "../{binary.filename}" "{url_hash}/{binary.filename}"',
        f'mkdir -p "{url_hash}"', 
        f'ln -s "../SHASUMS256.txt-29.1.0" "{url_hash}/SHASUMS256.txt"',
    ],
    destination=electron_cache_dir,
    only_arches=[binary.arch.flatpak],
)

Otherwise electron/get cannot find SHASUMS256.txt, tries to download it and fails.

[hfiguiere]

since you have a patch maybe you can submit a PR for it.

[savely-krasovsky]

@hfiguiere I am not fluent in Python and don't know how to properly pass SHASUM256.txt version. Patch above should be manually fixed for each Electron version.

[refi64]

I think this is fixed by #376?

[savely-krasovsky]

Yeah! I missed that PR, digged this issue myself...

[refi64]

PR is merged.