Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbidden file type prevents the upload of allowed file types #154

Open
Fraenkiman opened this issue Oct 1, 2022 · 0 comments
Open

Forbidden file type prevents the upload of allowed file types #154

Fraenkiman opened this issue Oct 1, 2022 · 0 comments
Labels

Comments

@Fraenkiman
Copy link
Collaborator

Hello, everyone,

When testing issue #152, the following was noticed:
If the uploader of a mixed file type selection contains a non-permitted file type, the subsequent permitted file types will also not be uploaded. There was also no "negative message" displayed; in the sense: "File(s) uploaded, but an error occurred."
I tested the following file type order: *.png, *.gif, *.jpg, *.php, *.zip, *rar, *.mp4 and *.avi
As a result, *.zip, *rar, *.mp4 and *.avi were not uploaded. The same behavior if a *.png, *.gif and *.jpg file type follows the non-permitted file.

So that the error list does not have to be expanded unnecessarily, I recommend displaying a negative message. This encourages the user to check the uploaded files.

The second option would be - with more work - to upload all permitted files despite the illegal file type.

Option three would be to include a newly defined error in the error list; as in: "File(s) uploaded, but an error occurred." This signals the user that although the upload of some files was successful, something went wrong.

Best Regards
Frank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants