Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bytes/Fixed compatibility and Serde #169

Open
dgrijalva-squire opened this issue Dec 17, 2020 · 1 comment
Open

Bytes/Fixed compatibility and Serde #169

dgrijalva-squire opened this issue Dec 17, 2020 · 1 comment

Comments

@dgrijalva-squire
Copy link
Contributor

I've been struggling to get Serde working on a schema that uses fixed fields. It appears there's no mapping between Serde and Value::Fixed. It looks like this could be supported if we added a few mappings to Value that allow coercion between Bytes and Fixed as long as the size matches.

Am I just doing it wrong? Would you accept a PR that adds this support?

@poros
Copy link
Collaborator

poros commented Dec 30, 2020

Hi, apologies for the late reply.
We are aware of one issue with Fixed and default values (see #96 and #66), but not that it is completely broken (it should be used as base for some of the logical types and we should have tests for those).
If you have some code to reproduce the bug, we could turn it into a unit test.

You are welcome to contribute, of course! Have a look in the codebase and submit a PR as you see fit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants