Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increasing Decimal Logical Types Support #187

Open
AlexRiedler opened this issue Apr 12, 2021 · 0 comments
Open

Increasing Decimal Logical Types Support #187

AlexRiedler opened this issue Apr 12, 2021 · 0 comments

Comments

@AlexRiedler
Copy link

I work a fair bit with logical types, and noticed we could probably increase support a fair bit by adding precision and scale to our decoded logical types (or even better potentially add support for bigdecimal crate).

I tried to implement this, was going to give it a PR but ran into an issue that would require significant refactoring of the code, and the public interface 😢 . In particular, the BigInt provided in Decimal type currently could be more than the number of bytes supported by the Fixed field and its unclear how to return an error in this case when encoding.

Suggestions on how to move forward on this? or should we just panic like we currently do?

AlexRiedler@0ac5e1f is my current change-set if you are interested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant