Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making a request now triggers plugin/post-scripts of all requests #278

Closed
kobenguyent opened this issue Oct 11, 2024 · 10 comments
Closed

Making a request now triggers plugin/post-scripts of all requests #278

kobenguyent opened this issue Oct 11, 2024 · 10 comments
Labels
bug Something isn't working

Comments

@kobenguyent
Copy link
Collaborator

I imported a postman collection, some requests have post scripts, some don't. However when I call a request without postscript, looking into console logs, all post scripts are now triggered.

for instance this request has only one test, but it calls 100+ tests from other requests.

Screenshot 2024-10-11 at 09 51 13

Screenshot 2024-10-11 at 09 47 50

@flawiddsouza
Copy link
Owner

I have been suspecting that there might be a bug in the import code. Related to postman.

Check your plugins in the navbar just in case. I have seen some stray global plugins appear.

Also, this seems like there are multiple scripts attached to the same collection id. Can you send your postman collection here (removing all sensitive data) so I can debug and fix this?

@flawiddsouza flawiddsouza added the bug Something isn't working label Oct 11, 2024
@kobenguyent
Copy link
Collaborator Author

not sure if that's related but when I have script on top folder, importing into restfox, shall we convert it as plugins?
Screenshot 2024-10-11 at 11 16 49

Attached collection: Debug.postman_collection.json

@kobenguyent
Copy link
Collaborator Author

I have been suspecting that there might be a bug in the import code. Related to postman.

Check your plugins in the navbar just in case. I have seen some stray global plugins appear.

Also, this seems like there are multiple scripts attached to the same collection id. Can you send your postman collection here (removing all sensitive data) so I can debug and fix this?

here you go
Too many tests.postman_collection.json

@flawiddsouza
Copy link
Owner

Thanks that really helped. Issue is that imported scripts have workspaceId filled for plugins data:
image

This shouldn't happen as anything with workspaceId is considered a workspace level plugin. I've pushed a fix.

@flawiddsouza
Copy link
Owner

flawiddsouza commented Oct 11, 2024

The issue becomes obvious when you open the plugins for the workspace from the navbar:
image
You see lots of empty workspace plugins.

@flawiddsouza
Copy link
Owner

not sure if that's related but when I have script on top folder, importing into restfox, shall we convert it as plugins? Screenshot 2024-10-11 at 11 16 49

Attached collection: Debug.postman_collection.json

Yes that should be good.

@flawiddsouza
Copy link
Owner

By the way, I'm really glad you caught this bug. I've noticed the random empty plugins once in a while in the workspace plugins list and it had been bothering me. Didn't know what was causing it. Had it in my todo list to check it out.

@kobenguyent
Copy link
Collaborator Author

By the way, I'm really glad you caught this bug. I've noticed the random empty plugins once in a while in the workspace plugins list and it had been bothering me. Didn't know what was causing it. Had it in my todo list to check it out.

nice to hear that issue has been resolved.

@kobenguyent
Copy link
Collaborator Author

kobenguyent commented Oct 11, 2024

Screenshot 2024-10-11 at 17 39 50

hey @flawiddsouza just found one thing, I set post script at grandchild 1 folder, but it was lost when importing into restfox.

@flawiddsouza
Copy link
Owner

Send your PR. I'll look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants