Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] polylines with only 1 point #1274

Closed
paul-gdy opened this issue Jun 13, 2022 · 2 comments
Closed

[BUG] polylines with only 1 point #1274

paul-gdy opened this issue Jun 13, 2022 · 2 comments
Labels
bug This issue reports broken functionality or another error invalid This bug could not be reproduced or does not exist, or is very low quality

Comments

@paul-gdy
Copy link

Hi,

I talked about it in this commit. However as I'm not a regular github user I think it will be easier to comment here.

I understand that path.addPolygon is better than path.lineTo (comment).
But I notice that path.addPolygon needs at least 2 points. In my case, I have to display lines with only 1 point.

Thus would it be possible to be sure the line is drawn even if it has only 1 point.

@paul-gdy paul-gdy added bug This issue reports broken functionality or another error needs triage This new bug report needs reproducing and prioritizing labels Jun 13, 2022
@ibrierley
Copy link
Collaborator

ibrierley commented Jun 13, 2022

Just for clarity, a line needs 2 points as well, it's just that the original had a bug in it, and added a duplicate 1st point by mistake (no matter how long the line). addPolygon just randomly happened to avoid that...(I'm not necessarily a fan of having a 2 point polygon, but I'll stay out of that one :D).

Is there a particular reason you can't add a 2nd identical point to your list ? That would be the correct thing to do.

@paul-gdy
Copy link
Author

It sounds good for me, thank you !

@JaffaKetchup JaffaKetchup added non-fatal invalid This bug could not be reproduced or does not exist, or is very low quality and removed needs triage This new bug report needs reproducing and prioritizing labels Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue reports broken functionality or another error invalid This bug could not be reproduced or does not exist, or is very low quality
Projects
None yet
Development

No branches or pull requests

3 participants