Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] <title> #1609

Closed
Henk-Keijzer opened this issue Aug 9, 2023 · 2 comments
Closed

[BUG] <title> #1609

Henk-Keijzer opened this issue Aug 9, 2023 · 2 comments
Labels
bug This issue reports broken functionality or another error duplicate This issue already exists

Comments

@Henk-Keijzer
Copy link

What is the bug?

Clickable links in the rich attribution window are active also when the attribution window is not visible.

How can we reproduce it?

  nonRotatedChildren: [
    RichAttributionWidget(
      popupBackgroundColor: Colors.white70,
      alignment: AttributionAlignment.bottomRight,
      showFlutterMapAttribution: false,
      permanentHeight: 32,
      attributions: [
        TextSourceAttribution(
          'Basiskaart: ${mapTileProviderData[selectedMapType]['attrib']}',
          textStyle: const TextStyle(color: Colors.black87),
          onTap: () => launchUrl(Uri.parse(mapTileProviderData[selectedMapType]['attribLink']),
              mode: LaunchMode.platformDefault)
        ),
        (mapOverlay && overlayTileProviderData.isNotEmpty) ? TextSourceAttribution(
          'Kaartoverlay: ${overlayTileProviderData[selectedOverlayType]['attrib']}',
          textStyle: const TextStyle(color: Colors.black87),
          onTap: () => launchUrl(Uri.parse(overlayTileProviderData[selectedOverlayType]['attribLink']),
            mode: LaunchMode.platformDefault)
        ) : const TextSourceAttribution(''),
        TextSourceAttribution('2011-${DateFormat('yyyy').format(DateTime.now())} Stichting Zeilvaart Warmond',
          textStyle: const TextStyle(color: Colors.black87),
          onTap: () => launchUrl(Uri.parse('https://www.zeilvaartwarmond.nl'))
        )
      ],
    ),
  ],

Do you have a potential solution?

No

Platforms

tested on Windows, Android, Web

Severity

Obtrusive: Prevents normal functioning but causes no errors in the console

@Henk-Keijzer Henk-Keijzer added bug This issue reports broken functionality or another error needs triage This new bug report needs reproducing and prioritizing labels Aug 9, 2023
@JaffaKetchup
Copy link
Member

Duplicate of #1589

@JaffaKetchup JaffaKetchup added duplicate This issue already exists and removed needs triage This new bug report needs reproducing and prioritizing labels Aug 9, 2023
@JaffaKetchup JaffaKetchup closed this as not planned Won't fix, can't repro, duplicate, stale Aug 9, 2023
@JaffaKetchup
Copy link
Member

Fixed by #1591, available on the master branch and v6 prereleases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue reports broken functionality or another error duplicate This issue already exists
Projects
None yet
Development

No branches or pull requests

2 participants