Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: View with content crashes in some routing scenarios #1001

Merged
merged 4 commits into from
Feb 8, 2023

Conversation

FeodorFitsner
Copy link
Contributor

No description provided.

@FeodorFitsner FeodorFitsner merged commit 5812e3b into main Feb 8, 2023
@FeodorFitsner FeodorFitsner deleted the view-child-racing branch February 8, 2023 18:00
@ndonkoHenri
Copy link
Contributor

What was the issue please?
You can push a prerelease so I can give it a try.

@FeodorFitsner
Copy link
Contributor Author

Racing condition. It occurs with Flutter animations/transitions, like in your case a routing view has been already removed from a page, but routing animation is still happening.

@FeodorFitsner
Copy link
Contributor Author

You can try the fix with pre-release. It's ready.

@ndonkoHenri
Copy link
Contributor

Hey! I just tried with the latest pre, and same issue. Requirements.txt: flet==0.5.0.dev1181
https://startup-name-generator.pages.dev/

@FeodorFitsner
Copy link
Contributor Author

It's still loading 0.4.0, not the latest pre. You should publish it with --pre:

flet publish your-script.py --pre

image

@ndonkoHenri
Copy link
Contributor

Ah, i forgot that parameter.
Feed-back tomorrow please 😴

@ndonkoHenri
Copy link
Contributor

Hey. It's still not working. Can you check if the flet pre was successfully loaded?

@FeodorFitsner
Copy link
Contributor Author

If you look at index.html sources you'll see that loading of pre-release packages from PyPI is not enabled (flet publish your-script.py --pre sets it to true):

image

and it's still loading 0.4.0:

image

@ndonkoHenri
Copy link
Contributor

I ran it with the --pre this Time.
No Problem, I will do it once more, and let you know.

berecik pushed a commit to Marysia-Software-Limited/flet that referenced this pull request Apr 3, 2023
* Update __str__ for command

* dart pub publish --force --dry-run

* Remove drt run

* Fix: View with content crashes in some routing scenarios

Fixed flet-dev#996
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants