Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discussion: Include a slugifier? #145

Closed
mikaelho opened this issue Aug 4, 2022 · 2 comments
Closed

Discussion: Include a slugifier? #145

mikaelho opened this issue Aug 4, 2022 · 2 comments

Comments

@mikaelho
Copy link
Contributor

mikaelho commented Aug 4, 2022

As flet now has support for routes i.e. deep linking, would it make sense to include a slugifier for internal use, i.e. for the use of components like ResponsiveMenuLayout without requiring developers to add requirements?

This could be a simple 5-line implementation like the one in ResponsiveMenuLayout, or vendoring some existing slugifier library, if expanding the requirements is not attractive.
@FeodorFitsner
Copy link
Contributor

FeodorFitsner commented Aug 4, 2022 •
edited
Loading

Your implementation looks pretty good to me. No need for 3rd-party packages. We could include slugify it to flet.utils namespace.

@FeodorFitsner
Copy link
Contributor

Feel free to submit a PR with the method.

@mikaelho mikaelho mentioned this issue Aug 6, 2022
Merged
@mikaelho mikaelho closed this as completed Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FeodorFitsner @mikaelho