Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder __init__ #2724

Merged
merged 15 commits into from
Mar 1, 2024
Merged

Reorder __init__ #2724

merged 15 commits into from
Mar 1, 2024

Conversation

ndonkoHenri
Copy link
Contributor

Closes #2722

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@FeodorFitsner
Copy link
Contributor

General note: those *String literal values used in Enum-like properties - they have been replaced with only Enums.
I think they could be safely removed from types.py as well as from imports of respective controls.

# Conflicts:
#	sdk/python/packages/flet-core/src/flet_core/checkbox.py
#	sdk/python/packages/flet-core/src/flet_core/cupertino_button.py
#	sdk/python/packages/flet-core/src/flet_core/icon_button.py
#	sdk/python/packages/flet-core/src/flet_core/list_tile.py
#	sdk/python/packages/flet-core/src/flet_core/outlined_button.py
#	sdk/python/packages/flet-core/src/flet_core/popup_menu_button.py
#	sdk/python/packages/flet-core/src/flet_core/radio.py
#	sdk/python/packages/flet-core/src/flet_core/switch.py
@FeodorFitsner FeodorFitsner merged commit 60fc766 into main Mar 1, 2024
2 checks passed
@ndonkoHenri ndonkoHenri deleted the reorder-init branch March 1, 2024 06:35
zrr1999 pushed a commit to zrr1999/flet that referenced this pull request Jul 17, 2024
* initial commit

* remove unused maintain_aspect_ratio

* reorder buttons prop

* reformat charts __init__

* reformat canvas __init__

* remove `__set_*` methods - Moving away from Literals in favour of Enums

* add deprecation docstring

* label as first init prop

* remove *String literals

* SearchBar: pass text attribute to close_view sync

* fix failing CI: remove Checkbox.__set_label_position

* fix failing CI: label_style and Enum import

* fix fix failing CI: scroll._set_attr

---------

Co-authored-by: Feodor Fitsner <feodor@appveyor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reorder __init__ properties
2 participants