Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web: patch html title with app_name #2909

Merged
merged 1 commit into from
Apr 3, 2024
Merged

web: patch html title with app_name #2909

merged 1 commit into from
Apr 3, 2024

Conversation

johnnychen94
Copy link
Contributor

This allows flet_fastapi to substitute the generated HTML <title> without introducing the custom index.html, e.g.,

flet_fastapi.app(
            webapp_main,
            app_name="my app",
            app_short_name="myapp",
            app_description="myapp description",
        )

@johnnychen94 johnnychen94 force-pushed the jc/html_patch_for_title branch from ef34817 to 4a4daa5 Compare March 19, 2024 06:29
@FeodorFitsner FeodorFitsner merged commit adbf44f into flet-dev:main Apr 3, 2024
2 checks passed
@johnnychen94 johnnychen94 deleted the jc/html_patch_for_title branch April 3, 2024 01:18
zrr1999 pushed a commit to zrr1999/flet that referenced this pull request Jul 17, 2024
@johnnychen94 @zrr1999
web: patch html title with app_name (flet-dev#2909)
4c64bc7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FeodorFitsner FeodorFitsner FeodorFitsner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnnychen94 @FeodorFitsner