Enhance Typing of Event Handlers #3523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request enhances the typing of event handlers across multiple files by introducing the OptionalEventCallable type. It updates the type annotations for event handler parameters to use this new type and simplifies event handler lambda functions by removing json.loads and directly passing the event. File-Level Changes
Tips
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @ndonkoHenri - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 7 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Comment on lines
-173
to
174
| self.__on_tap_down = EventHandler(lambda e: TapEvent(**json.loads(e.data))) | ||
| self.__on_tap_down = EventHandler(lambda e: TapEvent(e)) | ||
| self._add_event_handler("tap_down", self.__on_tap_down.get_handler()) |
There was a problem hiding this comment.
issue (bug_risk): Potential data loss in event handler
The change from json.loads(e.data) to e directly in the event handler might lead to data loss if e is not a JSON string. Ensure that e is always a JSON string or modify the TapEvent class to handle raw event data appropriately.
| @@ -53,9 +59,12 @@ def __init__(self, path, files) -> None: | |||
|
|
|||
There was a problem hiding this comment.
issue (bug_risk): Potential issue with file list handling
Ensure that d["files"] is always a list. If there's a possibility of it being None or another type, additional checks might be necessary to avoid runtime errors.
|
+1 |
FeodorFitsner
approved these changes
Jun 24, 2024
FeodorFitsner
approved these changes
Jun 24, 2024
zrr1999
pushed a commit
to zrr1999/flet
that referenced
this pull request
Jul 17, 2024
* Enhance typing of event handlers | reformat *Event classes * rename OptionalEventCallback to OptionalEventCallable --------- Co-authored-by: Feodor Fitsner <feodor@appveyor.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
This pull request enhances the typing of event handlers across multiple modules by introducing the OptionalEventCallable type. It simplifies event handler initialization and improves type safety and clarity in the codebase.