-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: wrap View
s into a background container
#3820
Conversation
Reviewer's Guide by SourceryThis pull request introduces a new feature to wrap File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ndonkoHenri - I've reviewed your changes - here's some feedback:
Overall Comments:
- The change in
client/macos/Runner/AppDelegate.swift
from@NSApplicationMain
to@main
seems unrelated to the main purpose of this PR. Could you explain the reasoning behind this change?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Yes sir! 🙂
|
Description
Closes #3743
Test Code
Screenshots (if applicable):
Summary by Sourcery
Add support for background and foreground decorations in View and Container components, enabling more flexible UI designs. Enhance border radius parsing with default values and update macOS client code to use modern Swift attributes.
New Features:
Enhancements: