Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MainActivity_kt.onCreate injection is not working #1566

Closed
aurimasmi opened this issue May 22, 2024 · 0 comments
Closed

MainActivity_kt.onCreate injection is not working #1566

aurimasmi opened this issue May 22, 2024 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@aurimasmi
Copy link
Collaborator

Describe the bug

If I try to do onCreate injection via renative.json plugin config it's being ignored.

To Reproduce
Steps to reproduce the behavior:

  1. Create plugin definition in renative.json I took react-native as example:
"react-native": {
    "version": "0.73.4",
    "android": {
        "path": "react-native",
        "templateAndroid": {
            "MainActivity_kt": {
                "onCreate": "super.onCreate(null)"
            }
        }
    }
}
  1. Build project npx rnv run -p android and observe results

Expected behavior

MainActivity.kt file has super.onCreate(null) function in onCreate method

Desktop (please complete the following information):

  • RNV Version 1.0.0-rc.19
@aurimasmi aurimasmi added the bug Something isn't working label May 22, 2024
@ElenaDiachenko ElenaDiachenko self-assigned this May 23, 2024
@ElenaDiachenko ElenaDiachenko added this to the 1.0 milestone May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants