Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REGRESSION] commandExistsSync incorrectly returns false in some cases #1630

Closed
locksten opened this issue Jul 17, 2024 · 0 comments
Closed

[REGRESSION] commandExistsSync incorrectly returns false in some cases #1630

locksten opened this issue Jul 17, 2024 · 0 comments
Assignees
@ElenaDiachenko
Labels
bug Something isn't working
Milestone
1.1

Comments

@locksten
Copy link
Collaborator

locksten commented Jul 17, 2024 •
edited
Loading

Describe the bug
commandExistsSync("somecmd") returns false if somecmd doesn't support the --version option or exits with a non-zero exit code.

To Reproduce
Call commandExistsSync("unzip").

Expected behavior
It should return true, but returns false instead.

Desktop

  • OS: macOS
  • Node Version v18.19.0
  • RNV Version 1.0.0-rc.21

Additional context
Not all commands support --version, so commandExistsSync should not rely on it.
Regressed here.
@locksten locksten added the bug Something isn't working label Jul 17, 2024
@locksten locksten added this to the 1.0 milestone Jul 17, 2024
@ElenaDiachenko ElenaDiachenko mentioned this issue Jul 18, 2024
Merged
@pavjacko pavjacko modified the milestones: 1.0, 1.1 Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElenaDiachenko ElenaDiachenko

Labels
bug Something isn't working
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
4 participants
@pavjacko @locksten @pauliusguzas @ElenaDiachenko