fix/choosing_apple_device #1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GabrieleKaceviciute
requested changes
Oct 10, 2024
There was a problem hiding this comment.
at least one device is active:
npx rnv run -p ios -t device name-> doesn't find device. Expected - install to specified device.npx rnv run -p ios -t random-> asks from simulators. Expected - ask from simulators and active devices.npx rnv run -p ios -d -t device IP-> asks from active device. Expected - install to specified device.npx rnv run -p ios -t device IP-> asks from simulators. Expected - install to specified device.npx rnv run -p ios -t random IP-> asks from simulators. Expected - ask from simulators and active devices.
Note: same on tvos.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const target = c.runtime.target?.replace(/(\s+)/g, '\\$1'); | ||
|
|
||
| p = `--simulator ${target}`; | ||
| p = `--simulator ${target}`; |
Check warning
Code scanning / CodeQL
Unsafe shell command constructed from library input Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 2 months ago
To fix the problem, we should avoid using string concatenation to construct the shell command. Instead, we can use child_process.execFile to safely pass the arguments to the command without risking shell injection. This approach ensures that the input is treated as an argument rather than part of the command string.
Suggested changeset
1
packages/sdk-apple/src/runner.ts
| @@ -79,5 +79,5 @@ | ||
| if (selectedDevice.udid) { | ||
| p = `--udid ${selectedDevice.udid}`; | ||
| p = ['--udid', selectedDevice.udid]; | ||
| } else { | ||
| p = `--device ${selectedDevice.name}`; | ||
| p = ['--device', selectedDevice.name]; | ||
| } | ||
| @@ -217,5 +217,5 @@ | ||
| if (!desiredSim?.isDevice) { | ||
| const target = c.runtime.target?.replace(/(\s+)/g, '\\$1'); | ||
| const target = c.runtime.target; | ||
|
|
||
| p = `--simulator ${target}`; | ||
| p = ['--simulator', target]; | ||
| } else { |
Copilot is powered by AI and may make mistakes. Always verify output.
GabrieleKaceviciute
approved these changes
Oct 14, 2024
aurimasmi
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
npx rnv run -p ios -d -t randominstalls app when 1 device is connected #1741npx rnv run -p ios -d -tdoesn't ask to choose from device list when 1 device is available #1740Npm releases
n/a