Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't depend on jQuery #320

Closed
hwclass opened this issue Oct 29, 2014 · 9 comments
Closed

Don't depend on jQuery #320

hwclass opened this issue Oct 29, 2014 · 9 comments
Milestone

Comments

@hwclass
Copy link

hwclass commented Oct 29, 2014

Hi the creators of Flightjs,

This is just a recommendation. Do you have any idea to avoid the dependency over jQuery and make a build of Flightjs without it?

Thanks.

@tgvashworth
Copy link
Contributor

Hi @hwclass — currently, Flight has a hard dependency on jQuery. A jQuery-less version has been built before, but we haven't got it to a finished state yet. I'll try to convince @danwrong to put up a pull request for it.

@giuseppeg
Copy link
Contributor

@PhUU @danwrong if you make it public (push to a dev branch) we could fork/help.

@kbingman
Copy link

kbingman commented Nov 5, 2014

@PhUU @danwrong yeah, I would be interested in looking at that very much and helping out.

@hwclass
Copy link
Author

hwclass commented Nov 6, 2014

@PhUU @danwrong great, good news. The base strcuture of flight encourages developers to develop apps with seperation of concers, so to remove the dependency over jQuery would be a good work to do for the future of the framework. I would also be interested in developing something else for that work. Thanks..

@margaritis
Copy link
Contributor

👍

1 similar comment
@panesofglass
Copy link

👍

@tgvashworth tgvashworth changed the title jQuery dependency to be independence from Don't depend on jQuery Jan 13, 2015
@tgvashworth tgvashworth added this to the 2.0.0 milestone Jan 14, 2015
@tgvashworth
Copy link
Contributor

WIP is on the feature/remove-jquery-320 branch.

@tunderdomb
Copy link

+1
I'd really love to see a lightweight version without the dependency too.

Also, out of curiosity, why did you decide to make it a requirement in the first place? I mean I can see this framework stand on its own without it just fine. Thanks!

@tgvashworth
Copy link
Contributor

So this is actually kinda done. v2 isn't ready to use yet, but as of recently it doesn't use jQuery! Woo!

This issue on the flight-toolbox will track adding jQuery back if you want it, via a dom plugin replacement of some kind. The specifics of that are yet to be worked out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants