-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roadmap for 2.6.0 release #517
Comments
FYI, here are the windows failures,
Tests pass
|
Thanks. This will be very helpful, though I won't be able to do anything about it until I get back from holidays in a little over a month. |
@isuruf Do you agree the Windows problems are now resolved? If so, I will tick that off the roadmap. |
@wbhart, no, the failing tests are simply disabled in appveyor. They still fail last I checked |
@isuruf Ah, I was not aware of that. Glad I checked! |
Will #585 (flush standard output in flint_memory_error) be in FLINT 2.6? |
Someone suggested we should just write to stderr instead. So I'm not sure at this point. |
@slel yes. |
@isuruf I have fixed the cmp_ui test. However, I am getting nowhere with t-factor. The appveyor --output-on-failure is broken. It doesn't display all lines of output when a test times out. I tried putting printf's in to see where the hang is, and if I remove earlier printf's some later printf's begin to show up. If I remove a couple more earlier printf's no printf's at all show up in the appveyor output! Do you know how to make all output show up? I can't find any documentation of the ctest option at all. |
It's ok, I figured it out. ctest is the cmake command, not an appveyor command, and --verbose is the right option. However, no output is showing up for that test. Not even a print of the test iteration shows up. I can't imagine what is causing this. |
@wbhart, maybe flush the stdout? |
I see that it works now. If you would like to, you can login to an appveyor node for an hour (including the time it takes to run the CI) using RDP. |
Yeah that did it. I now think the hang is in fmpz_poly_CLD_bound. We had a hang here on Linux which was fixed. I'm now wondering if MPIR-2.7.0 might be the issue. Those functions rely on the new versions in MPIR-3.0.0 I think. |
On Windows 64 I mean. 2.7.2 is fine on Linux, obviously. On the other hand the gcc version passes. I don't see why that would be as a long should still be 32 bits there I think. |
3.0.0 is problematic because of the issue https://groups.google.com/forum/#!search/Flint$2C$20MPIR$20and$20Windows$20compatibility/mpir-devel/htQR38wtrxQ/-BC1LeAmAQAJ |
Can also reduce the timeout to 1min. |
I did fix this issue. Unfortunately I don't remember where I fixed it, whether in Flint or MPIR. If the latter then only a build of mpir from master is going to work. I guess we'll see in a few minutes. |
By the way, Brian Gladman reports that on his box MSVC passes the t-factor test on Win64, but a different test fails (not the one I fixed). He uses his own visual solution files. |
Apparently @thofma has been using GMP-6.1.2 and MPFR-4.0.2 with Flint on Windows 64. We could try those instead. |
By the way, I disabled the login again. I couldn't find the source code once in there, and don't know how to run the build anyway, since I'm not familiar with this development platform. Also, just doing dir caused it to crash and print weird things, so it's not really stable enough to use. |
Here are the instructions, if you are interested.
|
Thanks, I might actually give it a go. It's just hanging in random places which makes no sense at all. I'm beginning to wonder if there is interference from a virus scanner, though I still think that's a less likely possibility. |
Just to make sure, I ran the tests in Azure Pipeline CI. Same issue. |
I randomly found the bug while inserting traces. It was actually a pretty serious bug, but I've no idea why it was only showing up on MSVC. Anyhow, that has probably saved a few days of very painful debugging that probably wouldn't have gotten anywhere. |
I'll close this now as all the ideas have been put into separate tickets, and we have the Milestone for keeping track of progress in the actual release. |
The following are optional for a release, but highly desirable:
Memory manager needs a threaded pooled allocatorThe text was updated successfully, but these errors were encountered: