Skip to content

Commit 9cd483d

Browse files
committed
Auto merge of rust-lang#10786 - mickvangelderen:remove-unnecessary-clone-from-needless-collect-example, r=Alexendoo
Remove unnecessary `clone` from `needless_collect` example The example for [clippy::needless_collect](https://rust-lang.github.io/rust-clippy/master/#needless_collect) is written as follows: ```rust let len = iterator.clone().collect::<Vec<_>>().len(); // should be let len = iterator.count(); ``` With this change, the unnecessary `clone()` is removed and the the standard ### Example ```rust // original ``` Use instead: ```rust // improved ``` structure is followed. Discussion: rust-lang/rust-clippy#10784 (comment) changelog: [`needless_collect`]: Cleaned up the example in the lint documentation.
2 parents f3f6fd8 + 79eb06c commit 9cd483d

File tree

1 file changed

+5
-2
lines changed
  • clippy_lints/src/methods

1 file changed

+5
-2
lines changed

Diff for: clippy_lints/src/methods/mod.rs

+5-2
Original file line numberDiff line numberDiff line change
@@ -3133,8 +3133,11 @@ declare_clippy_lint! {
31333133
/// ### Example
31343134
/// ```rust
31353135
/// # let iterator = vec![1].into_iter();
3136-
/// let len = iterator.clone().collect::<Vec<_>>().len();
3137-
/// // should be
3136+
/// let len = iterator.collect::<Vec<_>>().len();
3137+
/// ```
3138+
/// Use instead:
3139+
/// ```rust
3140+
/// # let iterator = vec![1].into_iter();
31383141
/// let len = iterator.count();
31393142
/// ```
31403143
#[clippy::version = "1.30.0"]

0 commit comments

Comments
 (0)