Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support logging to file #141

Closed
markphelps opened this issue Sep 30, 2019 · 4 comments · Fixed by #148
Closed

Support logging to file #141

markphelps opened this issue Sep 30, 2019 · 4 comments · Fixed by #148
Assignees

Comments

@markphelps
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Currently logs only go to STDOUT, would be great to support logging to the filesystem

Describe the solution you'd like
Support logging to file in configs

@markphelps markphelps self-assigned this Sep 30, 2019
@aaronraff
Copy link
Contributor

I am very new to this project but if you are looking for someone to lend a hand on either this issue or some other one, I would be happy to help out.

@markphelps
Copy link
Collaborator Author

Awesome. That would be great @aaronraff !

I was thinking it could be implemented somewhat like this: sirupsen/logrus#156 (comment)

With adding a field to the config: https://github.com/markphelps/flipt/blob/3430f47942167ce16a1e0fc6dd6272bd835584e4/config/local.yml#L1

Something like:

log:
  level:
  file: filename.log

I guess if file was empty or didn't exist it would just log to STDOUT like it currently does

@markphelps
Copy link
Collaborator Author

@all-contributors please add @aaronraff for code

@allcontributors
Copy link
Contributor

@markphelps

I've put up a pull request to add @aaronraff! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants