Introduce redef keyword

[magnus-madsen]

• Introduce redef keyword as a short hand for override def.
• Refactor the standard library and tests to use redef.
• Remove support for override. (Or better put it behind --Xdeprecated flag)
• Update the KeywordOtherCompleter (new in, old out)
• Update VSCode keywords (new in, old out)
• Update Highlight.js keywords (new in, old out)
• Update doc.flix.dev
• Update flix.dev

Note: This should not concern visibility, so this changes nothing w.r.t. pub.

[magnus-madsen]

@jaschdoc Next I would drop the requirement that declarations in instances must be public.

Then you can refactor instances to use redef (and not be public).

[jaschdoc]

Okay but this goes against what you wrote above. New design? :)

[magnus-madsen]

What do you mean? I suppose what I was trying to communicate is that first changing everything to use redef, and then changing everything to drop pub seems like double work. Might as well do it in one pass.

[jaschdoc]

Should I also remove the pub constraint in the trait declaration?

[magnus-madsen]

What do you mean? I am only asking for changes to instances at this time.

[jaschdoc]

Alright. In Rust the pub keyword is unused on trait declarations because it defines an interface where all members are public. I though that it would be relevant to this. I will, however, only rework the instances for now.

[jaschdoc]

But do we allow private functions on a trait declaration?

[magnus-madsen]

But do we allow private functions on a trait declaration?

We have not decided. But it could make sense.

[jaschdoc]

• Introduce redef keyword as a short hand for override def.
• Refactor the standard library and tests to use redef.
• Remove support for override. (Or better put it behind --Xdeprecated flag)
• Deprecate pub keyword for instances
• Update the KeywordOtherCompleter (new in, old out)
• Update VSCode keywords (new in, old out)
• Update Highlight.js keywords (new in, old out)
• Update doc.flix.dev
• Update flix.dev

[magnus-madsen]

I think we just need to get rid of the pub in pub redef for instances.

[jaschdoc]

I think we can close this now