Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes stream behavior #46

Closed
iliakan opened this issue Feb 8, 2016 · 4 comments
Closed

Changes stream behavior #46

iliakan opened this issue Feb 8, 2016 · 4 comments

Comments

@iliakan
Copy link

iliakan commented Feb 8, 2016

Observe this:

var vfs = require('vinyl-fs');
var plumber = require('gulp-plumber');

var stream = vfs.src(__filename)
  .pipe(plumber())
  .pipe(vfs.dest('/tmp'))
  .on('data', function() {
    console.log("Never happens")
  });

The on('data') on the last stream never happens. But it should.

@iliakan
Copy link
Author

iliakan commented Feb 9, 2016

Tracked the problem down to nodejs/node#1041.

The problem is in unpipe of the sink stream that happens because of assigning once('readable') handler by plumber.
It stops the flow.

@floatdrop
Copy link
Owner

Hi! Thanks for investigation, I'm honestly do not remeber, why readable is used in this place. It will be removed in next version.

@iliakan
Copy link
Author

iliakan commented Feb 9, 2016

@floatdrop the possible reason for it in issues: #7 (comment)

Maybe remove it now if not needed? :)

@floatdrop
Copy link
Owner

@iliakan removed in 1.1.0 – tests are still green, so there should be no problems now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants