Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vinyl as gulp-watch causes issues when the latest vinyl-fs #295

Open
asgoth opened this issue Dec 15, 2017 · 3 comments
Open

Update vinyl as gulp-watch causes issues when the latest vinyl-fs #295

asgoth opened this issue Dec 15, 2017 · 3 comments

Comments

@asgoth
Copy link

asgoth commented Dec 15, 2017

Since updating to vinyl-fs version 3.x, I'm getting the error file.isSymbolic is not a function.

After some investigation, it seems to be caused by an outdated vinyl version in gulp-watch. Could you please update vinyl to 2.1.0?

For now, i'm using a workaround:

/**
 * gulp-watch uses an outdated vinyl, which doesn't have some functions which vinyl-fs expects.
 * Can be removed when gulp-watch updates it to vinyl 2.x.
 * @returns {NodeJS.ReadWriteStream}
 */
function upgradeVinylFile(): NodeJS.ReadWriteStream {
  return through.obj(function(file: any, encoding: string, cb: through.TransformCallback): void {
    const upgradedFile = new File(file);
    cb(null, upgradedFile);
  });
}

@phated
Copy link
Contributor

phated commented Dec 16, 2017

👍 plugins will need to upgrade to a version of vinyl that supports isVinyl()

@dozer75
Copy link

dozer75 commented Dec 22, 2017

Usage is broken with gulp 4.0.0-alpha.3, see gulpjs/gulp#2065.

@FranklinYu
Copy link

So, are we ready to remove dependency over gulp-util?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants