eth_sign not implemented

[dekz]

It appears that eth_sign is not implemented forcing users to use personal_sign. Is there any particular reason for this? personal_sign doesn't actually have a JSON-RPC definition or a relevant EIP.

if (payload.method === 'eth_sign') return this.resError('No eth_sign, please use personal_sign', payload, res)

Found here

Other Web3 wallets actually do this incorrectly. Continuing to support these functions for some need of backwards compatible dApps also hurts the ecosystem, old dApps aren't broken (few), new dApps (many) must create work arounds when being spec compliant. See MetaMask/metamask-extension#2215

We created EIP712 to help get around this and show the user what they are signing, so I'm happy #136 exists.

[floating]

Thanks @dekz, this makes sense and I agree. I will implement eth_sign in the next release.

[floating]

eth_sign implementation merged into master and will be in release v0.1.2 soon

[dekz]

thanks @floating!