Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.3.0 Beta phase #269

Closed
marcelklehr opened this issue Apr 25, 2019 · 13 comments
Closed

v3.3.0 Beta phase #269

marcelklehr opened this issue Apr 25, 2019 · 13 comments

Comments

@marcelklehr
Copy link
Member

marcelklehr commented Apr 25, 2019

Hello there,

if you're up for a bit of testing in order to get an earlier glimpse at the new features of the upcoming floccus version, you're welcome to follow the guide below :)

Changes:

  • Improved sync algorithm: better performance by loading a sparse tree (i.e. only the changed parts of the server tree)
  • Internationalization: German, French, Portuguese and Russian are done already, if you'd like to help, head over to Translation #266
  • Sync interval option: You can now specify how long floccus should wait before syncing again, if no changes have happened locally
  • Improved mobile support (Kiwi browser now supports floccus on android 🎉)

Installation

Chrome (separate testing installation)

Chrome (direct upgrade; might not always work)

Firefox (separate testing installation; cannot upgrade)

Cheers! 👾
Marcel

@marcelklehr
Copy link
Member Author

Beta 2 is out now.

@tkurbad
Copy link

tkurbad commented May 21, 2019

Hi @marcelklehr,

thanks for the betas. Runs flawlessly so far for me against NC 16.0.0 with latest bookmarks app. Nice work!

I also like to internationalized and optically improved interface.

Best,
Torsten

@akidburn
Copy link

Hi,
Beta 2 works a lot faster than the normal version, though if i read the logs right there is still something iffy, because about 500 bookmarks out of 3800 are still compared one to one, not in sparse trees. And depending on the browser (firefox or chrome) there are between 5 and 50 updates to bookmarks, although i didnt change anything.

akidburn

@marcelklehr
Copy link
Member Author

Thanks for the feedback @tkurbad and @akidburn!
I'll investigate the unnecessary comparisons :)

@marcelklehr
Copy link
Member Author

beta 3 is out now 🎉

@akidburn Could you try again, if this fixes your issue?

@tkurbad
Copy link

tkurbad commented May 28, 2019

@marcelklehr I'm unable to install it. For the .crx, Chromium gives me "Invalid CRX header", when trying to install the unpacked zip, it complains about a missing Manifest in builds.

Chromium 73.0.3683.86 on Linux, if that matters...

@marcelklehr
Copy link
Member Author

marcelklehr commented May 28, 2019

Mh. the invalid CRX header is probably to be expected as these are unsigned builds. The zip should work, though... I've updated the install instructions above, to be more specific.

@tkurbad
Copy link

tkurbad commented May 28, 2019

@marcelklehr was able to install it now. Problem was that I've been too far down the directory tree. However, when I click "Add Account", nothing happens, even after browser restart.

@marcelklehr
Copy link
Member Author

Oh, my bad. Beta 4 should fix that as well.

@tkurbad
Copy link

tkurbad commented May 29, 2019

@marcelklehr Works for me.

@akidburn
Copy link

akidburn commented May 30, 2019

@marcelklehr Works for me as well, though the performance hit in firefox is pretty damning if the speedup option is chosen, freezes most other addons and prevents loading new tabs

but the sparse trees work now

Edit:
As I understand it, the whole local bookmark tree is hashed in one go, right?
Would it be possible to slow it artificialy, or to separate it into more threads, so the addons process doesnt freeze completely?

Because with close to 4000 bookmarks, the tree generation on firefox takes about 3 minutes, and every other addon is frozen in this time.

@marcelklehr
Copy link
Member Author

As I understand it, the whole local bookmark tree is hashed in one go, right?

Yes, it's a hash tree and all branches are hashed in parallel. I've serialized this, now, in beta 5

@marcelklehr marcelklehr unpinned this issue Jun 9, 2019
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
@marcelklehr marcelklehr moved this to Done in Floccus May 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done
Development

No branches or pull requests

3 participants