-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add convenience script for (re-)building #127
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: BenBE <BenBE@geshi.org>
Co-authored-by: BenBE <BenBE@geshi.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have attempted to address all issues you mentioned now :)
@BenBE Could you explain what is unclear about the usecase (as you added the "needs usecase" label)? The idea is to make the setup of backscrub less error prone and more convenient, especially for less technical users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the subshell
Howdy, thanks for this 😄 Given the intention is to make it easier for non-technical folks, would it be useful to ensure dependencies are installed as well as automating the instructions in the README? If so, perhaps using a CMake based mechanism similar to (if not exactly the same!) as Tensorflow uses would be effective? Can I assume that backing up the Last thought - do we want to update the Please note: just questions for later, I'm happy this is merged as-is, then we can think about my random questions! |
I added the label for the other devs to have a look at this and chime in pro/con this change. Given the comments from @phlash I think resolving the dependency re-download issue should be addressed; apart from that there's only minor stylistic things (missing escapes for the path argument in the trap call, e.g.) that I'd to in a later review. |
@phlash Thanks, these are very good points :)
That's a good idea. I'm not quite sure how easy it would be to do this distro-agnostic, though (and my knowledge about CMake is quite limited), so we'd need to see how to implement this.
No, I added that just to avoid breaking the setup. Everything is rebuilt anyways. However, if you use the script for updating backscrub and something breaks (e.g. a dependency is missing or an environment variable is set wrongly), users will still have their working pre-update version. |
I've created this script for myself, but figured, others might benefit as well.
Tested on Linux (Ubuntu 20.04, but that shouldn't matter)