Endless Activity Indicator when calling presentFacebookAlbumImagePicker

[RGBNu]

Hello - Since the most recent update, when I call presentFacebookAlbumImagePicker, it presents the picker correctly, but never shows any images, no Facebook login screen, nothing.

• In the console I see : Found 31 album(s) with this Facebook account.
• The error or success delegate methods are never called.

Not really sure what other info I can share.. It was definitely working well in the last version. Any thoughts?

[floriangbh]

Hello @RGBNu,

Can you reproduce this with the demo project ?
I'll check this asap.

Thanks

[RGBNu]

Hello - I put a project to reproduce this issue at www.kx1.us/FBTest.zip

Since it is the most basic possible implementation of the FacebookImagePicker, I assume it must be something with our Facebook Developer account. (This test project uses an Info.plist from the other project.) But without any error feedback, I can't figure what it is.

Another update, it looks like the login screen does appear, just not the albums.

Thanks for the quick reply!

[floriangbh]

Hello @RGBNu,
I just tried with your demo project with my facebook account and all the albums are showing up !
Maybe this is an issue with your album's types which are not handle by the picker ?

[RGBNu]

Dang, that is very surprising. All my albums are pretty normal I think.. I've uploaded pics from desktop and my iOS device, that's about it.

One other thing to note is both myself and another tester were seeing this behavior. One thing we have in common is that we are both admins on our Facebook app. I wonder if that could be part of it? Just looking for any commonality.

[floriangbh]

I'm also admin of the facebook demo app (which are in this repo) and I don't have any problem for showing my album. So I don't think it's your problem.
Keep me informed if you find the problem. I leave this issue open in case other people have the same issue :)

[floriangbh]

Hello @RGBNu , did you find the solution of your problem?

[RGBNu]

Greetings Florian -

After digging into your code and setting a million breakpoints, I figured out what's going on. In the class FacebookController, there is a segment of code beginning on line 81 which attempts to retry the next page by calling fetchFacebookAlbums again (line 87). However, the completion is not being passed back into the function call, resulting in the completion being nil on line 91, therefore render is never called in FacebookAlbumController, line 91. The fix was simple, just pass the completion back into the subsequent calls in FacebookController line 87.

Hope that helps!

[floriangbh]

Many thanks ! :-)

Sorry for this bug, I didn't test to fetch a lot of album since the first version...

I'll fix it and make a new release.

[floriangbh]

The v3.0.1 is now available with this fix, thanks !

[RGBNu]

Greetings Florian --

I think we missed a slight detail on this issue. The request for albums now works with pagination, but the request for images within those albums still fails in the same way (endless spinner, no completion passed back in.) I tried to do a Pull Request, but I forget how to do it, ha. Anyway, in the file FacebookController.swift, change line 174 to selfStrong.fbAlbumsPictureRequest(after: after, album: album, completion: completion) Cheers!

[floriangbh]

Hello @RGBNu, you can try this version : https://github.com/floriangbh/FacebookImagePicker/releases/tag/3.0.2 :-)
Cheers !