Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escapes in the release title break everything #596

Closed
EagleoutIce opened this issue Jan 15, 2024 · 0 comments · Fixed by #601
Closed

Escapes in the release title break everything #596

EagleoutIce opened this issue Jan 15, 2024 · 0 comments · Fixed by #601
Assignees
@Ellpeck
Labels
bug Something isn't working meta Deals with the Repository itself, the CI, Issue management, ...

Comments

@EagleoutIce
Copy link
Member

A title containing backticks when using release:patch is not sanitized (used as msg="[release:patch] Drop `readlines/promises` Dependency") and hence wants to execute readlines/promises in the given example!

This must be prevented and sanitized!
@EagleoutIce EagleoutIce added bug Something isn't working meta Deals with the Repository itself, the CI, Issue management, ... labels Jan 15, 2024
@Ellpeck Ellpeck self-assigned this Jan 17, 2024
@Ellpeck Ellpeck linked a pull request Jan 17, 2024 that will close this issue
Fix: Escapes in the release title break everything #601
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ellpeck Ellpeck

Labels
bug Something isn't working meta Deals with the Repository itself, the CI, Issue management, ...
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Escapes in the release title break everything flowr-analysis/flowr
2 participants
@Ellpeck @EagleoutIce