Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a startup configuration file for flowr #642

Closed
1 task done
Ellpeck opened this issue Feb 6, 2024 · 2 comments · Fixed by #651
Closed
1 task done

Add a startup configuration file for flowr #642

Ellpeck opened this issue Feb 6, 2024 · 2 comments · Fixed by #651
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Ellpeck
Copy link
Member

Ellpeck commented Feb 6, 2024

Configuration files should be parsed from the current working directory or parent directories (?) as well as next to the executable (?)

Options we want to support:

@Ellpeck Ellpeck changed the title it is configurable (so that when starting the dataflow analysis one can configure flowR so that Add a startup configuration file for flowr Feb 6, 2024
@Ellpeck Ellpeck added enhancement New feature or request good first issue Good for newcomers labels Feb 6, 2024
@Ellpeck Ellpeck self-assigned this Feb 6, 2024
@Ellpeck
Copy link
Member Author

Ellpeck commented Feb 6, 2024

@EagleoutIce Would you mind specifying some more info about what you think the configuration file should be, specifically

  • paths that get checked: should we do the "move upwards through parent directories indefinitely and find all config files there" thing? should we check the executable directory in addition to the working directory?
  • config parsing: should checking multiple files cause entries to be overridden/merged? If so, in what direction?
  • config format: should the config file be json? or yaml? or something else?

@EagleoutIce
Copy link
Member

I would say:

  • move upwards the dir chain until a configuration is found
  • we only use the "closest" definition (maybe, later, we can talk about global defaults etc.)
  • i think a json is easiest to implement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants