Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter: add rules for consistent spacing in imports and objects #673

Closed
Ellpeck opened this issue Feb 23, 2024 · 1 comment · Fixed by #688
Closed

Linter: add rules for consistent spacing in imports and objects #673

Ellpeck opened this issue Feb 23, 2024 · 1 comment · Fixed by #688
Labels
enhancement New feature or request good first issue Good for newcomers linting Related to linting rules and refactors

Comments

@Ellpeck
Copy link
Member

Ellpeck commented Feb 23, 2024

Currently, imports and object can have various styles:

import { something } from "somewhere"
import {something} from "somewhere"

let obj = { some: value }
let obj = {some: value}
let obj = {some: value   }
@Ellpeck Ellpeck added enhancement New feature or request good first issue Good for newcomers linting Related to linting rules and refactors labels Feb 23, 2024
@EagleoutIce
Copy link
Member

We want:

import { something } from "somewhere"

For object denotations i am not sure because they are usually multiline :D but i think i prefer the space variant.

@bjthehun bjthehun mentioned this issue Feb 23, 2024
4 tasks
@EagleoutIce EagleoutIce linked a pull request Feb 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers linting Related to linting rules and refactors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants