Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify/outsource ESLint rules and GH actions so that all repositories can use them #699

Closed
Ellpeck opened this issue Mar 5, 2024 · 2 comments · Fixed by #742
Closed

Unify/outsource ESLint rules and GH actions so that all repositories can use them #699

Ellpeck opened this issue Mar 5, 2024 · 2 comments · Fixed by #742
Labels
high priority Probably best done before other issues. linting Related to linting rules and refactors meta Deals with the Repository itself, the CI, Issue management, ...

Comments

@Ellpeck
Copy link
Member

Ellpeck commented Mar 5, 2024

This is especially important for vscode-flowr, which currently uses a copy of this repository's eslint rules.
@Ellpeck Ellpeck added meta Deals with the Repository itself, the CI, Issue management, ... linting Related to linting rules and refactors labels Mar 5, 2024
This was referenced Mar 5, 2024
Merged
Merged
@Ellpeck Ellpeck changed the title Unify/outsource ESLint rules so that all repositories can use them Unify/outsource ESLint rules and GH actions so that all repositories can use them Mar 5, 2024
@Ellpeck
Copy link
Member Author

Ellpeck commented Mar 5, 2024

See also workflows and git hooks added by flowr-analysis/vscode-flowr#11

@Ellpeck Ellpeck mentioned this issue Mar 21, 2024
Closed
@Ellpeck Ellpeck added the high priority Probably best done before other issues. label Mar 21, 2024
@Ellpeck
Copy link
Member Author

Ellpeck commented Mar 22, 2024 •
edited
Loading

  • Use npm for eslint rules
  • Move CI actions to their own repository
  • Move modules to their own repositories and publish their own npm packages
  • Make cli, statistics, benchmark etc. into submodules and ensure that people cloning without submodules get notified that they cloned without submodules
  • Reintroduce the plugin that allows separating code parts without being allowed to import them again

@Ellpeck Ellpeck linked a pull request Mar 22, 2024 that will close this issue
Unify/outsource ESLint rules and GH actions so that all repositories can use them #742
Merged
@Ellpeck Ellpeck mentioned this issue Mar 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
high priority Probably best done before other issues. linting Related to linting rules and refactors meta Deals with the Repository itself, the CI, Issue management, ...
Projects
None yet
Milestone
No milestone
1 participant
@Ellpeck