Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Claims don't match tests for some labels #820

Closed
Ellpeck opened this issue May 24, 2024 · 4 comments
Closed

Claims don't match tests for some labels #820

Ellpeck opened this issue May 24, 2024 · 4 comments
Labels
done The issue is only open as it relates to a larger feature which is not yet completed test Relates to tests specifically

Comments

@Ellpeck
Copy link
Member

Ellpeck commented May 24, 2024

Notably, the labels built-in-sequencing and accessing-internal-names have the unsupported claim, but various tests that claim to include them.

@Ellpeck Ellpeck added the test Relates to tests specifically label May 24, 2024
@EagleoutIce
Copy link
Member

Can you be more specific please? Are these the only ones?

@Ellpeck
Copy link
Member Author

Ellpeck commented May 24, 2024

Yes, it appears that way. Here are their reports:

    [1/2/9] Accessing Internal Names (claim: not supported) is covered by 1 test:
          - desugar [1]: #304

      [2/1/10/3] Sequencing (claim: not supported) is covered by 22 tests:
            - dataflow [5]: #69-#70, #99, #119-#120
            - desugar [7]: #400-#404, #490-#491
            - slice [10]: #647, #653-#654, #660-#666
            - output [2]: #647, #660

@EagleoutIce
Copy link
Member

So, the access of internal names label should be removed as we just use the ::: token and not really resolve anything there. Sequencing on the other hand should be updated like this:

  1. the description in data.ts should state that this refers to the abstract interpretation support (i.e., contributing information on the value domain). Consequently, the label should be removed from all tests exposing it (or in other words, we treat it as a simple binary operator). Can you do that? @Ellpeck

@EagleoutIce EagleoutIce added the done The issue is only open as it relates to a larger feature which is not yet completed label May 24, 2024
@EagleoutIce
Copy link
Member

This issue has been resolved in v2.0.2 (see Release v2.0.2 (Fixing Control-Flow, Markdown-Exports, and Handling of Unnamed Closures)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done The issue is only open as it relates to a larger feature which is not yet completed test Relates to tests specifically
Projects
None yet
Development

No branches or pull requests

2 participants