Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate flowR out into modules (properly this time) #829

Open
Ellpeck opened this issue May 28, 2024 · 0 comments
Open

Separate flowR out into modules (properly this time) #829

Ellpeck opened this issue May 28, 2024 · 0 comments
Labels
dependencies Pull requests or issues that update a dependency file meta Deals with the Repository itself, the CI, Issue management, ...

Comments

@Ellpeck
Copy link
Member

Ellpeck commented May 28, 2024

We attempted this once before, with separate repos, and it didn't go particularly well. We'd like for components like the CLI, the benchmarking, and the statistics to all be separate modules, but with some important points to keep in mind:

  • they should be in the same repo for maintainability (we could potentially use changesets for release management)
  • cross-dependencies should be local (rather than through npm) so that, for example, code changes to flowR's dataflow analysis can immediately be benchmarked without having to create a release
  • flowR core's dependencies should be kept as minimal as possible, to avoid issues like Various flowR dependencies stop it from being webpack-able #757
@Ellpeck Ellpeck added the meta Deals with the Repository itself, the CI, Issue management, ... label May 28, 2024
@EagleoutIce EagleoutIce added the dependencies Pull requests or issues that update a dependency file label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests or issues that update a dependency file meta Deals with the Repository itself, the CI, Issue management, ...
Projects
None yet
Development

No branches or pull requests

2 participants