Add missing features in `useLSP` mode #295

Mayank1791989 · 2018-12-08T10:17:33Z

Fix most of the issues listed in #243.

Changes

add TypeCoverage
add Server Status
add Rename
add stopFlowOnExit support
add runOnEdit partial support (only report syntax errors)
fix flow lint errors not showing up.
reimplement language-server using flow lsp (remove flow-language-server)
.flowconfig syntax highlighting

changes useLSP mode - use `flow lsp` to implement language server (remove flow-language-server) - add TypeCoverage - add Status - add Rename - add `stopFlowOnExit` support - add `runOnEdit` partial support (only report syntax errors)

facebook-github-bot · 2018-12-08T10:17:48Z

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot · 2018-12-08T10:18:50Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

thymikee · 2018-12-08T10:39:41Z

I've tried to run this locally, but can't see flow status or an option to enable coverage (tried settings as well), also looks like the hover middleware is not kicking in, as I see text as plaintext when hovering. Is there any other special setup I need to make to test it properly?

EDIT: tested on Flow 0.81 and 0.87

Mayank1791989 · 2018-12-08T12:00:50Z

@thymikee did you compile the code?

thymikee · 2018-12-08T12:02:00Z

yup, with cmd+b (got confirmation that everything was compiled by Babel)

Mayank1791989 · 2018-12-08T12:04:34Z

Remove your old build folder and run compile again. May be old flowLSP.js file present in build dir.

thymikee · 2018-12-08T12:06:08Z

LOL, that worked 🤦‍♂️

Mayank1791989 · 2018-12-08T12:06:46Z

: ) We have to fix the compile script.

Mayank1791989 · 2018-12-08T12:16:38Z

Done

thymikee · 2018-12-08T12:17:37Z

Works really well, thank you so much for taking that over! I could never find time to do it properly.

I guess that rename is still in early development? I got it crashed 2 times, once it worked but with a bug, and now I can't make it work (trying on latest Flow). EDIT: and now I can, welp.

cc @orta give it a spin

Mayank1791989 · 2018-12-08T12:23:20Z

Is there any error log in plugin console? For me rename works fine. Make sure you save files after renaming.

thymikee · 2018-12-08T12:37:02Z

None in the extension console, but I get this output in the Panel's Output tab:

[Error - 1:31:00 PM] Request textDocument/rename failed.
  Message: Failure("Failure(\"unexpected args passed to instantiate_poly_t: AnnotT\")")
  Code: -32001 
[object Object]
[Error - 1:31:07 PM] Request textDocument/documentHighlight failed.
  Message: Failure("Failure(\"unexpected args passed to instantiate_poly_t: AnnotT\")")
  Code: -32001 
[object Object]
[Error - 1:31:11 PM] Request textDocument/completion failed.
  Message: Failure("Failure(\"unexpected args passed to instantiate_poly_t: AnnotT\")\nRaised at file \"pervasives.ml\", line 32, characters 17-33\nCalled from file \"src/typing/flow_js.ml\", line 12074, characters 21-51\nCalled from file \"src/typing/flow_js.ml\", line 12241, characters 12-34\nCalled from file \"src/typing/flow_js.ml\", line 12181, characters 25-58\nCalled from file \"src/typing/flow_js.ml\", line 12242, characters 4-24\nCalled from file \"src/server/command_handler/commandHandler.ml\", line 67, characters 21-93\nCalled from file \"src/core/lwt.ml\", line 2101, characters 16-20")
  Code: -32001 
[object Object]

Anyway, rename doesn't work for me in most cases and it's not really reproducible, seems to be happening randomly, regardless window being restarted etc.

Mayank1791989 · 2018-12-08T12:43:47Z

Which version of flow are you using? As this bug was fixed in flow 0.84 (see issue).

thymikee · 2018-12-08T12:47:43Z

Oh yea, I forgot I switched to the other project with older Flow to test it as well. I got this bug on 0.81, and taking a look now, I couldn't see it in 0.87 so you're right about the fix. And rename seems to now work on 0.87 as expected now (I have no idea why it wasn't first time I tested it on this project).

Mayank1791989 · 2018-12-08T12:51:48Z

Currently the hover output doesnt look very good (using js-beautify). I will send a separate PR replacing it with prettier.

thymikee · 2018-12-08T12:53:04Z

replacing it with prettier

I was about to suggest that.

Mayank1791989 · 2018-12-08T12:57:48Z

Locally I am using prettier only but not included in this PR to keep this PR small. If it's fine then I will push the commit.

thymikee · 2018-12-08T12:59:24Z

How do you feel about removing the duplication in status bar? One label should be just enough

What I think makes sense is to put the coverage message the same as the status when restarting server, and make it e.g. Flow (86% coverage)

Locally I am using prettier only but not included in this PR to keep this PR small. If it's fine then I will push the commit.

Changes in yarn.lock don't really count :D

orta · 2018-12-14T18:30:08Z

OK, cool, I'll give this a spin today 👍

…into feat/lsp

other changes - implement status actions

orta · 2018-12-14T19:39:09Z

This is feeling awesome! Let's get this in ASAP. IMO, feels good enough to warrant LSP being the default.

…nto feat/lsp

orta · 2018-12-14T20:59:01Z

To get flow to pass, I think you'll need to add these bits of the vscode dts to the flow-typed definition in the repo, should remove most errors

changes - add type defn for vscode-* packages - fix flow errors - update bundled flow to v0.75 NOTE: this can be breaking change for users using plugin bundled flow (v0.68) - update flow-typed defn

changes - request coverage only if connected to server - recompute coverage when server gets connected (will fix missing coverage for initial file)

jbrown215 · 2018-12-18T20:16:25Z

FWIW, flow officially recommended vscode + this plugin as the recommended way to use Flow: https://twitter.com/flowtype/status/1073258441723006981

It would be really awesome if LSP becomes the default configuration!

jbrown215 · 2018-12-18T20:17:52Z

.flowconfig


 [version]
-^0.68.0
+^0.75.0


The most recent flow version is 0.89.0. Is there a reason you don't want to use the most recent version?

Reason for updating to 0.75 is to avoid breaking changes to users relying on bundled flow 0.68. I was planning to use v0.89 in a separate commit. Anyways, we released v1.0 so it's fine.

thymikee · 2018-12-18T21:09:41Z

lib/flowLSP/features/Status/Status.js


  dispose() {
-    this.statusBarItem.dispose();
-    this._clearTimeout();
+    this._command.dispose();


can we dispose StatusProvider as well, just not to forget about it?

@thymikee Actually there is nothing in StatusProvider to dispose so I kept it this way.

I remember a comment about adding such in StatusProvider. Maybe worth removing it?

Hmm I should remove the onStatus listener in dispose method. As provider and status component both disposes together it will not cause any issues but I will push a fix thanks.

…nto feat/lsp

orta · 2018-12-19T00:10:54Z

OK, I've added a changelog entry, bumped this package to version 1.0 because this feels like the right time, and addressed the rest of the feedback in this PR

orta · 2018-12-19T00:12:46Z

I'm gonna merge, ship and build this, and not announce for a day or two to see if any issues rain in.

It's been working fine for me in the Jest codebase, which has been a pretty good indicator for me in the past.

orta · 2018-12-19T00:16:10Z

Congrats @Mayank1791989 and thanks!

jbrown215 · 2018-12-19T03:05:08Z

@orta and @Mayank1791989: Would one of you want to write a blog post about flow-for-vscode 1.0 and the features it supports? We could put it on the flow blog and tweet it out!

orta · 2018-12-19T09:58:45Z

@jbrown215 that sounds like a good idea, @Mayank1791989 can you email me to say hi (my email is in my GH profile) ?

Mayank1791989 added 3 commits December 8, 2018 15:04

chore(babel): update babel to v7

3211665

feat(syntax): enable syntax highlighting in .flowconfig

1f56e9e

fix(useLsp): add missing features in lsp mode.

3f33b0a

changes useLSP mode - use `flow lsp` to implement language server (remove flow-language-server) - add TypeCoverage - add Status - add Rename - add `stopFlowOnExit` support - add `runOnEdit` partial support (only report syntax errors)

facebook-github-bot added the CLA Signed label Dec 8, 2018

chore(build): clean old build before starting new compilation

baee2f0

fix(formatting): use prettier to format output

7af1f28

thymikee mentioned this pull request Dec 13, 2018

[WIP][RFC] Move to native flow LSP #297

Closed

orta and others added 2 commits December 14, 2018 13:33

Merge branch 'master' of https://github.com/flowtype/flow-for-vscode …

852bcac

…into feat/lsp

fix(lsp): merge status and coverage bar item

2ecc125

other changes - implement status actions

Merge branch 'feat/lsp' of github.com:Mayank1791989/flow-for-vscode i…

9ea86db

…nto feat/lsp

Mayank1791989 added 4 commits December 16, 2018 23:09

fix(lsp): fix multiple output channel

a215448

fix: update flow to 0.75 and fix all flow errors

8642d61

changes - add type defn for vscode-* packages - fix flow errors - update bundled flow to v0.75 NOTE: this can be breaking change for users using plugin bundled flow (v0.68) - update flow-typed defn

feat(lsp): add version & flowconfig check

222e3c5

fix(coverage): fix missing coverage in some cases

a93157c

changes - request coverage only if connected to server - recompute coverage when server gets connected (will fix missing coverage for initial file)

jbrown215 reviewed Dec 18, 2018

View reviewed changes

thymikee reviewed Dec 18, 2018

View reviewed changes

orta added 3 commits December 19, 2018 00:03

Merge branch 'feat/lsp' of github.com:Mayank1791989/flow-for-vscode i…

051752e

…nto feat/lsp

Address all feedback in flow#295

06a414c

Convert LSP to be the default, and migrate to version 1.0

a31f31a

orta merged commit bf28f0e into flow:master Dec 19, 2018

jamesisaac mentioned this pull request Dec 27, 2018

[RFC] Migrate Jest to TypeScript jestjs/jest#7554

Closed

Mayank1791989 deleted the feat/lsp branch February 16, 2019 07:34

Mayank1791989 mentioned this pull request Jun 7, 2019

Show "Warning" level errors. #180

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add missing features in `useLSP` mode #295

Add missing features in `useLSP` mode #295

Mayank1791989 commented Dec 8, 2018 •

edited

Loading

facebook-github-bot commented Dec 8, 2018

facebook-github-bot commented Dec 8, 2018

thymikee commented Dec 8, 2018 •

edited

Loading

Mayank1791989 commented Dec 8, 2018

thymikee commented Dec 8, 2018

Mayank1791989 commented Dec 8, 2018

thymikee commented Dec 8, 2018

Mayank1791989 commented Dec 8, 2018

Mayank1791989 commented Dec 8, 2018

thymikee commented Dec 8, 2018 •

edited

Loading

Mayank1791989 commented Dec 8, 2018 •

edited

Loading

thymikee commented Dec 8, 2018

Mayank1791989 commented Dec 8, 2018

thymikee commented Dec 8, 2018

Mayank1791989 commented Dec 8, 2018 •

edited

Loading

thymikee commented Dec 8, 2018

Mayank1791989 commented Dec 8, 2018

thymikee commented Dec 8, 2018

orta commented Dec 14, 2018

orta commented Dec 14, 2018

orta commented Dec 14, 2018

jbrown215 commented Dec 18, 2018 •

edited

Loading

jbrown215 Dec 18, 2018

Mayank1791989 Dec 19, 2018

thymikee Dec 18, 2018

Mayank1791989 Dec 19, 2018

thymikee Dec 19, 2018

Mayank1791989 Dec 19, 2018

orta commented Dec 19, 2018 •

edited

Loading

orta commented Dec 19, 2018 •

edited

Loading

orta commented Dec 19, 2018

jbrown215 commented Dec 19, 2018

orta commented Dec 19, 2018

Add missing features in useLSP mode #295

Add missing features in useLSP mode #295

Conversation

Mayank1791989 commented Dec 8, 2018 • edited Loading

facebook-github-bot commented Dec 8, 2018

facebook-github-bot commented Dec 8, 2018

thymikee commented Dec 8, 2018 • edited Loading

Mayank1791989 commented Dec 8, 2018

thymikee commented Dec 8, 2018

Mayank1791989 commented Dec 8, 2018

thymikee commented Dec 8, 2018

Mayank1791989 commented Dec 8, 2018

Mayank1791989 commented Dec 8, 2018

thymikee commented Dec 8, 2018 • edited Loading

Mayank1791989 commented Dec 8, 2018 • edited Loading

thymikee commented Dec 8, 2018

Mayank1791989 commented Dec 8, 2018

thymikee commented Dec 8, 2018

Mayank1791989 commented Dec 8, 2018 • edited Loading

thymikee commented Dec 8, 2018

Mayank1791989 commented Dec 8, 2018

thymikee commented Dec 8, 2018

orta commented Dec 14, 2018

orta commented Dec 14, 2018

orta commented Dec 14, 2018

jbrown215 commented Dec 18, 2018 • edited Loading

jbrown215 Dec 18, 2018

Choose a reason for hiding this comment

Mayank1791989 Dec 19, 2018

Choose a reason for hiding this comment

thymikee Dec 18, 2018

Choose a reason for hiding this comment

Mayank1791989 Dec 19, 2018

Choose a reason for hiding this comment

thymikee Dec 19, 2018

Choose a reason for hiding this comment

Mayank1791989 Dec 19, 2018

Choose a reason for hiding this comment

orta commented Dec 19, 2018 • edited Loading

orta commented Dec 19, 2018 • edited Loading

orta commented Dec 19, 2018

jbrown215 commented Dec 19, 2018

orta commented Dec 19, 2018

Add missing features in `useLSP` mode #295

Add missing features in `useLSP` mode #295

Mayank1791989 commented Dec 8, 2018 •

edited

Loading

thymikee commented Dec 8, 2018 •

edited

Loading

thymikee commented Dec 8, 2018 •

edited

Loading

Mayank1791989 commented Dec 8, 2018 •

edited

Loading

Mayank1791989 commented Dec 8, 2018 •

edited

Loading

jbrown215 commented Dec 18, 2018 •

edited

Loading

orta commented Dec 19, 2018 •

edited

Loading

orta commented Dec 19, 2018 •

edited

Loading